lkml.org 
[lkml]   [2017]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] mtd: mtdram: check offs and len in mtdram->point madram->unpoint,mtdram->write and mtdram->read
Date
    We should prevent user to erasing mtd device with
an unaligned offset or length.

Signed-off-by: Chen Wenyong <chenwy-fnst@cn.fujitsu.com>
---
drivers/mtd/devices/mtdram.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/mtd/devices/mtdram.c b/drivers/mtd/devices/mtdram.c
index cbd8547..b0468c1 100644
--- a/drivers/mtd/devices/mtdram.c
+++ b/drivers/mtd/devices/mtdram.c
@@ -67,6 +67,8 @@ static int ram_erase(struct mtd_info *mtd, struct erase_info *instr)
static int ram_point(struct mtd_info *mtd, loff_t from, size_t len,
size_t *retlen, void **virt, resource_size_t *phys)
{
+ if (check_offs_len(mtd, from, len))
+ return -EINVAL;
*virt = mtd->priv + from;
*retlen = len;
return 0;
@@ -74,6 +76,8 @@ static int ram_point(struct mtd_info *mtd, loff_t from, size_t len,

static int ram_unpoint(struct mtd_info *mtd, loff_t from, size_t len)
{
+ if (check_offs_len(mtd, from, len))
+ return -EINVAL;
return 0;
}

@@ -93,6 +97,8 @@ static unsigned long ram_get_unmapped_area(struct mtd_info *mtd,
static int ram_read(struct mtd_info *mtd, loff_t from, size_t len,
size_t *retlen, u_char *buf)
{
+ if (check_offs_len(mtd, from, len))
+ return -EINVAL;
memcpy(buf, mtd->priv + from, len);
*retlen = len;
return 0;
@@ -101,6 +107,8 @@ static int ram_read(struct mtd_info *mtd, loff_t from, size_t len,
static int ram_write(struct mtd_info *mtd, loff_t to, size_t len,
size_t *retlen, const u_char *buf)
{
+ if (check_offs_len(mtd, to, len))
+ return -EINVAL;
memcpy((char *)mtd->priv + to, buf, len);
*retlen = len;
return 0;
--
2.9.3


\
 
 \ /
  Last update: 2017-03-03 08:32    [W:0.038 / U:1.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site