lkml.org 
[lkml]   [2017]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Outreachy kernel] [PATCH] staging: speakup: else is not generally useful after a break or return
On Fri, Mar 03, 2017 at 05:03:09PM +0100, Julia Lawall wrote:
>
>
> On Fri, 3 Mar 2017, Arushi Singhal wrote:
>
> > fixed checkpatch.pl warning: else is not generally useful after a break
> > or return.
> > Removed the else without affecting the logic.
> > Dead code is also eliminated.
>
> The chhange is not correct. There is a big chain of if/else if. The if
> (type == KT_LATIN) can reach the code at the end of the file.
>

Yeah. And KT_CUR as well.

regards,
dan carpenter

\
 
 \ /
  Last update: 2017-03-03 18:51    [W:0.047 / U:2.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site