Messages in this thread | | | Date | Thu, 30 Mar 2017 09:54:42 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH 0/4] ftrace: Add 'function-fork' trace option (v1) |
| |
On Wed, 29 Mar 2017 10:46:21 +0900 Namhyung Kim <namhyung@kernel.org> wrote:
> Hello, > > This patchset add 'function-fork' option to function tracer which > makes pid filter to be inherited like 'event-fork' does. During the > test, I found a bug of pid filter on an instance directory. The patch > 1 fixes it and maybe it should go to the stable tree. > > The function-fork option is disabled by default as event-fork does, > but we might consider changing the default since it seems to be more > natural from an user's perspective IMHO.
By the way, I thought that event-fork option also effected to function tracer. Is there any reason we should separate those? I mean, we can add "trace-fork" option instead of "function-fork" for setting both pid filters at once.
Thank you,
> > The code is also available at 'ftrace/function-fork-v1' branch on > > git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git > > Thanks, > Namhyung > > > Namhyung Kim (4): > ftrace: Fix function pid filter on instances > ftrace: Add 'function-fork' trace option > selftests: ftrace: Add -l/--logdir option > selftests: ftrace: Add a testcase for function PID filter > > kernel/trace/ftrace.c | 47 ++++++++++- > kernel/trace/trace.c | 6 +- > kernel/trace/trace.h | 8 +- > tools/testing/selftests/ftrace/ftracetest | 5 ++ > .../ftrace/test.d/ftrace/func-filter-pid.tc | 98 ++++++++++++++++++++++ > 5 files changed, 158 insertions(+), 6 deletions(-) > create mode 100644 tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc > > -- > 2.12.0 >
-- Masami Hiramatsu <mhiramat@kernel.org>
| |