Messages in this thread | | | Date | Wed, 29 Mar 2017 23:01:43 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH] iommu/vt-d: Make sure IOMMUs are off when intel_iommu=off |
| |
On Wed, Mar 29, 2017 at 08:51:53AM -0700, Jacob Pan wrote: > On Wed, 29 Mar 2017 17:00:39 +0200 > Joerg Roedel <joro@8bytes.org> wrote:
> > +static void intel_disable_iommus(void) > > +{ > > + struct intel_iommu *iommu = NULL; > > + struct dmar_drhd_unit *drhd; > > + > > + for_each_iommu(iommu, drhd) > > + iommu_disable_translation(iommu); > should we also disable IR here? i.e. > iommu_disable_irq_remapping(iommu);
No, irq remapping depends on another parameter (intremap=off) and needs to be handled seperatly. I already looked at it and this needs to be part of a larger effort as it required changes in code-paths that are shared between Intel and AMD IOMMU drivers.
Joerg
| |