Messages in this thread | | | From | Linus Torvalds <> | Date | Wed, 29 Mar 2017 10:16:36 -0700 | Subject | Re: syscall_get_error() && TS_ checks |
| |
On Wed, Mar 29, 2017 at 10:04 AM, Oleg Nesterov <oleg@redhat.com> wrote: > > Oh, I agree, and let me repeat the 3rd time that I suggest to kill this > helper and use syscall_get_return_value() in arch/x86/kernel/signal.c, > it has no other callers.
That is probably fine, I'm just arguing against the suggested changes to syscall_get_error().
That said, I'm not sure why you want to change this in the first place? I think the current syscall_get_error() - with explicit compat handling and all - is fine.
But if the aim is to just remove syscall_get_error() entirely because it's so unused, then I'm ok with that.
Linus
| |