Messages in this thread | | | From | "Liang, Kan" <> | Subject | RE: [PATCH V4 1/2] x86/msr: expose msr_flip_bit function | Date | Wed, 29 Mar 2017 13:01:29 +0000 |
| |
> > -static inline int __flip_bit(u32 msr, u8 bit, bool set) > > +int msr_flip_bit(u32 msr, u8 bit, bool set) > > { > > struct msr m, m1; > > int err = -EINVAL; > > @@ -85,6 +85,7 @@ static inline int __flip_bit(u32 msr, u8 bit, bool > > set) > > > > return 1; > > } > > +EXPORT_SYMBOL_GPL(msr_flip_bit); > > That export is not required. The call site is always built in. >
If so, msr_set_bit/msr_clear_bit should be enough for our requirement. msr_flip_bit is just a duplicate interface. I think I will drop this patch.
Thanks, Kan
| |