lkml.org 
[lkml]   [2017]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 0/8] gpio: acpi: Make it working
On Thu, Mar 23, 2017 at 8:46 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> Currently GPIO ACPI library provides an API to get a GPIO resources
> (IO or interrupt) from ACPI tables for the individual drivers.
>
> This library has few flaws which makes some devices not working:
> - the library allows to abuse ACPI by using a _CRS fallback mechanism
> - the library neglects flags of the resource
>
> In this series:
> - the _CRS fallback is forbidden
> - the pin configuration follows what firmware wants to
> - the documentation is updated in order to clarify corner cases
>
> After this series it's possible to use GPIO pins for input (interrupt)
> which were configured as output by BIOS by some reason. It's a crucial
> functionality for IoT open connected boards where user may choose any of
> available pin for almost any of available function, including GPIO input
> (interrupt).
>
> Current bad behaviour was first reported by Jarkko Nikula few months ago.

I see there are some outstanding comments in the patches but it looks
OK overall to me, waiting for a v2 before applying, please collect ACKs
and relevant Tested-by:s.

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2017-03-28 16:02    [W:0.157 / U:2.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site