Messages in this thread | | | Subject | Re: [PATCH] scsi: hisi_sas: add missing break in switch statement | From | John Garry <> | Date | Tue, 28 Mar 2017 12:42:12 +0100 |
| |
On 28/03/2017 12:12, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > It appears that a break in the TRANS_TX_OPEN_CNX_ERR_NO_DESTINATION > case got accidentally removed in an earlier commit, as it stands, > the ts->stat and ts->open_rej_reason are being updated twice for this > case which looks incorrect. Fix this by adding in the missing break > statement. > > Detected by CoverityScan, CID#1422110 ("Missing break in switch") > > Fixes: 634a9585f49c7 ("scsi: hisi_sas: process error codes according to their priority") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, checkpatch.pl would normally catch this but it was hidden in the formatted patch
Signed-off-by: John Garry <john.garry@huawei.com>
| |