lkml.org 
[lkml]   [2017]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH v2 13/53] mtd: nand: denali_dt: enable HW_ECC_FIXUP for Altera SOCFPGA variant
On Thu, Mar 23, 2017 at 05:07:12AM +0900, Masahiro Yamada wrote:
> There are various customizable parameters, so several variants for
> this IP. A generic compatible like "denali,denali-nand-dt" is
> useless. Moreover, there are multiple things wrong with this string.
> (Refer to Rob's comment [1])
>
> The denali_dt.c was split out and this compatible was added by Altera
> for the SOCFPGA port. So, replace it with a more specific string.
>
> The Denali IP on SOCFPGA incorporates the hardware ECC fixup feature.
> So, this capability should be associated with the compatible string.
>
> [1] https://lkml.org/lkml/2016/12/1/450
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Changes in v2:
> - Add caps flag to of_device_id data, not hard-code in driver code
> - Add Altera-specific compatible.
>
> Documentation/devicetree/bindings/mtd/denali-nand.txt | 5 +++--
> drivers/mtd/nand/denali_dt.c | 14 ++++++++++----
> 2 files changed, 13 insertions(+), 6 deletions(-)

You should also mention there are no users (in-tree) of the old string.

Acked-by: Rob Herring <robh@kernel.org>

\
 
 \ /
  Last update: 2017-03-29 04:01    [W:0.213 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site