lkml.org 
[lkml]   [2017]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] selftests/futex: Fix build error with OUTPUT variable
Date
Darren Hart <dvhart@infradead.org> writes:

> The use of $$OUTPUT in the target shell commands resulted in an empty
> string followed by an absolute path for which mkdir failed:
>
> $ make -C tools/testing/selftests/futex
> make: Entering directory '/home/dvhart/source/linux/linux-pdx86/tools/testing/selftests/futex'
> Makefile:36: warning: overriding recipe for target 'clean'
> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
> for DIR in functional; do \
> BUILD_TARGET=$OUTPUT/$DIR; \
> mkdir $BUILD_TARGET -p; \
> make OUTPUT=$BUILD_TARGET -C $DIR all;\
> done
> mkdir: cannot create directory ‘/functional’: Permission denied
>
> Replace $$OUTPUT with $(OUTPUT) when referring to the Makefile OUTPUT
> variable. The above make command now completes successfully.
>
> Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
> Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
> Cc: linux-kselftest@vger.kernel.org
> Cc: bamvor.zhangjian@huawei.com
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: <stable@vger.kernel.org> # 4.10.x-

The OUTPUT support only went into v4.11-rc1, so I don't see why you need
a stable tag?

Change looks good though.

cheers

\
 
 \ /
  Last update: 2017-03-28 02:21    [W:0.066 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site