lkml.org 
[lkml]   [2017]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] mfd: ipaq-micro: Delete redundant return value check of platform_get_resource()
On Sat, 25 Mar 2017, Belen Sarabia wrote:

> devm_ioremap_resource does checks on the resource. No need to
> duplicate this in the driver.
>
> Signed-off-by: Belén Sarabia <belensarabia@gmail.com>
> ---
> Changes in v2:
> - Subject line expected by the subsystem.
> - Remove one line more.
> ---
> drivers/mfd/ipaq-micro.c | 3 ---
> 1 file changed, 3 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c
> index df16fd1..124aad2 100644
> --- a/drivers/mfd/ipaq-micro.c
> +++ b/drivers/mfd/ipaq-micro.c
> @@ -400,9 +400,6 @@ static int __init micro_probe(struct platform_device *pdev)
> micro->dev = &pdev->dev;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res)
> - return -EINVAL;
> -
> micro->base = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(micro->base))
> return PTR_ERR(micro->base);

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2017-03-27 14:43    [W:1.157 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site