Messages in this thread | | | From | Frans Klaver <> | Date | Mon, 27 Mar 2017 14:19:15 +0200 | Subject | Re: [PATCH v2] staging: goldfish: Fix style issues in macros |
| |
On Mon, Mar 27, 2017 at 2:13 PM, aviyae <aviyae42@gmail.com> wrote: > I'll remove that eudyptula thing, although there are some patches that mention it > > (run git log --grep=eudyptula)
I haven't checked that and I think it's a shame it didn't get removed. I don't think it adds value to the patch, as it's just for a personal goal.
It is also custom to reply _below_ the (part of the) message you're responding to by the way ;-).
Cheers, Frans
> On 27/03/17 15:05, Frans Klaver wrote: >> On Mon, Mar 27, 2017 at 1:52 PM, aviyae <aviyae42@gmail.com> wrote: >>> From: Aviya Erenfeld <aviyae42@gmail.com> >>> >>> staging: goldfish: Fix style issues in macros >>> >>> Fix coding style issues in macros: >>> 1. Add parenthesis around macros argument >>> 2. Avoid arguments reuse in macros >>> >>> (For the eudyptula challenge) >> How is that relevant? >> >> Frans >
| |