lkml.org 
[lkml]   [2017]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 0/7] efi: Enhance capsule loader to support signed Quark images
From
Date


On 24/03/17 17:34, Jan Kiszka wrote:
> This addresses the review feedback provided on round 1, specifically
> - refactored queue to keep the Quark mess in
> - only check for CSH on Quark CPUs
> - added some smaller cleanups of the capsule loader
> - documented capsule header / linked to original code
>
> See last patch for the background of the series.
>
> The series has been tested on the Galileo Gen2, to exclude regressions,
> with a firmware.cap with AND without security header and the SIMATIC
> IOT2040 which requires the header because of its mandatory secure boot.
>
> Jan
>
> Jan Kiszka (7):
> efi/capsule: Fix return code on failing kmap/vmap
> efi/capsule: Remove pr_debug on ENOMEM or EFAULT
> efi/capsule: Clean up pr_err/info messages
> efi/capsule: Adjust return type of efi_capsule_setup_info
> efi/capsule: Prepare for loading images with security header
> efi/capsule: Factor out overloadable efi_capsule_identify_image
> efi/capsule: Add support for Quark security header
>
> arch/x86/platform/efi/quirks.c | 95 ++++++++++++++++++++++++
> drivers/firmware/efi/capsule-loader.c | 136 +++++++++++++++++++---------------
> drivers/firmware/efi/capsule.c | 21 +++++-
> include/linux/efi.h | 19 +++++
> 4 files changed, 208 insertions(+), 63 deletions(-)
>

BTW,

Thanks for taking the time to remove the __func__ stuff all over the place.

I'll try to test this out for you. I found that the current BSP Intel is
releasing has some sort of GUI that downloads an image to a board (which
completely fails for me on the Galileo I have)... not sure if you have
different results with the stuff from the Intel website but it's
non-functional for me :(

I'd like to suggest to you adding something to Documentation describing
how to load and trigger a capsule update. For example on Quark you need
to use the EFI reset method to cause capsule update to work.

Could you add a patch to your series for Documentation detailing:

1. Entry criteria (needing to boot in EFI reset mode)
1. Description of loading a capsule
3. Description of triggering the update (reboot)
4. Verifying the update succeeded (actually is this possible right now?)

---
bod

\
 
 \ /
  Last update: 2017-03-27 12:38    [W:0.148 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site