lkml.org 
[lkml]   [2017]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: selinux: Delete an error message for a failed memory allocation in policydb_read()
    On Fri, Mar 24, 2017 at 8:13 AM, SF Markus Elfring
    <elfring@users.sourceforge.net> wrote:
    >>> Omit an extra message for a memory allocation failure in this function.
    >>>
    >>> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
    >>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    >>> ---
    >>> security/selinux/ss/policydb.c | 5 +----
    >>> 1 file changed, 1 insertion(+), 4 deletions(-)
    >>
    >> I'm not going to remove an error message without some better reasoning
    >> in the patch description. Providing a link to slides is fine, but
    >> your commit message needs to convey the important information and I
    >> don't think that is the case here (what happens when that URL dies?).
    >
    > Do you need an explicit reminder there that the function “kmalloc” provides its own
    > error reporting already because the flag “__GFP_NOWARN” was not passed here?

    That is what I said by "better reasoning in the patch description",
    however, now that I'm looking at this again, I don't think I'm going
    to merge this. Yes, maybe in some cases it is a bit wasteful, but I
    like the error message.

    --
    paul moore
    www.paul-moore.com

    \
     
     \ /
      Last update: 2017-03-25 16:46    [W:2.897 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site