Messages in this thread | | | Date | Fri, 24 Mar 2017 23:23:40 +0100 | From | Ralph Sennhauser <> | Subject | Re: [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan |
| |
On Fri, 24 Mar 2017 15:35:05 +0100 Andrew Lunn <andrew@lunn.ch> wrote:
> > + pwm_fan { > > /* SUNON HA4010V4-0000-C99 */ > > - compatible = "gpio-fan"; > > - gpios = <&gpio0 24 0>; > > > > - gpio-fan,speed-map = <0 0 > > - 4500 1>; > > + compatible = "pwm-fan"; > > + pwms = <&gpio0 24 4000 0>; > > Hi Ralph > > I believe this last 0 is the flags parameter. Now that we have > #pwm-cells = 1, i think this last 0 should be dropped. > > Andrew
Missed it. Duly noted like the other comments.
Thanks Ralph
| |