lkml.org 
[lkml]   [2017]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver
On Fri, Mar 24, 2017 at 05:45:41PM +0100, Bartlomiej Zolnierkiewicz wrote:
> > > > And I think the probe might be called twice, for example in case of
> > > > mistake in DTB.
> > >
> > > Even if this is possible resource allocation code in the driver will
> > > take take care of handling it just fine,
> >
> > Indeed, the devm_ioremap_resource() solves the case. I can drop the
> > check then.
>
> Looking on this a bit more it seems that devm_ioremap_resource() will
> not cover all mistakes (using compatible by mistake in some other DTB
> node).
>
> Leave the check, I take my objection back.

Great! Thanks for feedback.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2017-03-24 18:03    [W:0.782 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site