Messages in this thread | | | Date | Fri, 24 Mar 2017 22:12:50 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] crypto, x86: aesni - fix token pasting for clang |
| |
On Wed, Mar 15, 2017 at 03:36:00PM -0700, Michael Davidson wrote: > aes_ctrby8_avx-x86_64.S uses the C preprocessor for token pasting > of character sequences that are not valid preprocessor tokens. > While this is allowed when preprocessing assembler files it exposes > an incompatibilty between the clang and gcc preprocessors where > clang does not strip leading white space from macro parameters, > leading to the CONCAT(%xmm, i) macro expansion on line 96 resulting > in a token with a space character embedded in it. > > While this could be resolved by deleting the offending space character, > the assembler is perfectly capable of doing the token pasting correctly > for itself so we can just get rid of the preprocessor macros. > > Signed-off-by: Michael Davidson <md@google.com>
Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |