Messages in this thread | | | Subject | Re: [PATCH] ipmi_ssif: use setup_timer | From | Corey Minyard <> | Date | Fri, 24 Mar 2017 21:59:39 -0500 |
| |
A little nicer, yes. In queue for the next release.
Thanks,
-corey
On 03/24/2017 09:15 AM, Geliang Tang wrote: > Use setup_timer() instead of init_timer() to simplify the code. > > Signed-off-by: Geliang Tang <geliangtang@gmail.com> > --- > drivers/char/ipmi/ipmi_ssif.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c > index cca6e5b..a92a049 100644 > --- a/drivers/char/ipmi/ipmi_ssif.c > +++ b/drivers/char/ipmi/ipmi_ssif.c > @@ -1642,9 +1642,8 @@ static int ssif_probe(struct i2c_client *client, const struct i2c_device_id *id) > > spin_lock_init(&ssif_info->lock); > ssif_info->ssif_state = SSIF_NORMAL; > - init_timer(&ssif_info->retry_timer); > - ssif_info->retry_timer.data = (unsigned long) ssif_info; > - ssif_info->retry_timer.function = retry_timeout; > + setup_timer(&ssif_info->retry_timer, retry_timeout, > + (unsigned long)ssif_info); > > for (i = 0; i < SSIF_NUM_STATS; i++) > atomic_set(&ssif_info->stats[i], 0);
| |