Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 23 Mar 2017 14:41:53 +0100 | Subject | Re: [PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls |
| |
On Thu, Mar 23, 2017 at 1:34 PM, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> Maybe we can make gpiod_get_optional look like this: > > if (!dev->of_node && isnt_a_acpi_device(dev) && !IS_ENABLED(GPIOLIB)) > return NULL; > else > return -ENOSYS; > > I don't know how isnt_a_acpi_device looks like, probably it involves > CONFIG_ACPI and/or dev->acpi_node. > > This should be safe and still comfortable for legacy platforms, isn't it?
I like the looks of this.
Can we revert Dmitry's patch and apply something like this instead?
Dmitry, how do you feel about this?
Yours, Linus Walleij
| |