Messages in this thread | | | Subject | Re: [PATCH v7 4/6] i2c: designware: introducing I2C_SLAVE definitions | From | Jarkko Nikula <> | Date | Wed, 22 Mar 2017 16:53:15 +0200 |
| |
On 03/20/17 13:10, Luis Oliveira wrote: > - Definitions were added to core library > - A example was added to designware-core.txt Documentation that shows > how the slave can be setup using DTS > > SLAVE related definitions were added to the core of the controller. > > Signed-off-by: Luis Oliveira <lolivei@synopsys.com> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Acked-by: Rob Herring <robh@kernel.org> > --- > v6-v7 > - no changes > ... > +#define DW_IC_RX_ABRT_SLAVE_RD_INTX (1UL << ABRT_SLAVE_RD_INTX) > +#define DW_IC_RX_ABRT_SLAVE_ARBLOST (1UL << ABRT_SLAVE_ARBLOST) > +#define DW_IC_RX_ABRT_SLAVE_FLUSH_TXFIFO (1UL << ABRT_SLAVE_FLUSH_TXFIFO) > > #define DW_IC_TX_ABRT_NOACK (DW_IC_TX_ABRT_7B_ADDR_NOACK | \ > DW_IC_TX_ABRT_10ADDR1_NOACK | \ > @@ -211,6 +236,7 @@ struct dw_i2c_dev { > struct completion cmd_complete; > struct clk *clk; > struct reset_control *rst; > + struct i2c_client *slave; > u32 (*get_clk_rate_khz) (struct dw_i2c_dev *dev); > struct dw_pci_controller *controller; > int cmd_err; > @@ -230,6 +256,7 @@ struct dw_i2c_dev { > struct i2c_adapter adapter; > u32 functionality; > u32 master_cfg; > + u32 slave_cfg; > unsigned int tx_fifo_depth; > unsigned int rx_fifo_depth; > int rx_outstanding; > Here too I take my ack back. You should add comments for these added members.
-- Jarkko
| |