Messages in this thread | | | From | Kai-Heng Feng <> | Date | Wed, 22 Mar 2017 13:44:49 +0800 | Subject | Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode |
| |
On Tue, Mar 21, 2017 at 5:15 PM, Bard Liao <bardliao@realtek.com> wrote: >> -----Original Message----- >> From: Kai-Heng Feng [mailto:kai.heng.feng@canonical.com] >> Sent: Tuesday, March 21, 2017 1:26 PM >> To: Mark Brown >> Cc: Liam Girdwood; Bard Liao; Oder Chiou; alsa-devel@alsa-project.org; >> linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell >> XPS 9343 I2S mode >> > >> >> I had the same thought originally, but printk under each case suggests >> >> otherwise - _POST_PMU is triggered not right after _PRE_PMU but right >> >> before _PRE_PMD. >> > >> > Then you've broken something else on your system, that is obviously >> > completely nonsensical and would break anything that relies on having a >> > _POST_PMU event. Why would we have two events that run at the same >> time >> > one of which is obviously misnamed? >> >> Hmm, that's weird though. I did the same test to rt286_spk_event() >> (without applying the patch I sent), what I observed was the same: >> _POST_PMU was triggered right after I stopped play sound, i.e. right >> before _PRE_PMD not right after _PRE_PMU. >> > > Although I don't think it will happen on my side, but I still > ran the same test as you. The result is just as what we > expected, _PRE_PMU and _POST_PMU run on powering > up stage and _PRE_PMD and _POST_PMD run on powering > down stage. Please check what's going on with your system. >
Maybe mine is broken, maybe other XPS 9343 share the same behavior. I guess we need more users to provide information to continue the discussion.
> >> ------Please consider the environment before printing this e-mail.
| |