Messages in this thread | | | Date | Wed, 22 Mar 2017 11:13:15 +0530 | From | Gautham R Shenoy <> | Subject | Re: [v2 PATCH 3/4] powernv:idle: Don't override default/deepest directly in kernel |
| |
Hi,
On Tue, Mar 21, 2017 at 02:39:34AM +1000, Nicholas Piggin wrote: > > @@ -241,8 +240,9 @@ static DEVICE_ATTR(fastsleep_workaround_applyonce, 0600, > > * The default stop state that will be used by ppc_md.power_save > > * function on platforms that support stop instruction. > > */ > > -u64 pnv_default_stop_val; > > -u64 pnv_default_stop_mask; > > +static u64 pnv_default_stop_val; > > +static u64 pnv_default_stop_mask; > > +static bool default_stop_found; > > > > /* > > * Used for ppc_md.power_save which needs a function with no parameters > > @@ -262,8 +262,9 @@ static void power9_idle(void) > > * psscr value and mask of the deepest stop idle state. > > * Used when a cpu is offlined. > > */ > > -u64 pnv_deepest_stop_psscr_val; > > -u64 pnv_deepest_stop_psscr_mask; > > +static u64 pnv_deepest_stop_psscr_val; > > +static u64 pnv_deepest_stop_psscr_mask; > > +static bool deepest_stop_found; > > Aha you have made them static. Nitpick withdrawn :) > > The log messages look good now. > > Reviewed-by: Nicholas Piggin <npiggin@gmail.com> > Thanks!
-- Thanks and Regards gautham.
| |