Messages in this thread | | | Date | Wed, 22 Mar 2017 11:11:40 +0530 | From | Gautham R Shenoy <> | Subject | Re: [v2 PATCH 1/4] powernv: Move CPU-Offline idle state invocation from smp.c to idle.c |
| |
Hi Nick,
On Tue, Mar 21, 2017 at 02:35:17AM +1000, Nicholas Piggin wrote: > On Mon, 20 Mar 2017 21:24:15 +0530 > "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> wrote: > > > From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> > > > > Move the piece of code in powernv/smp.c::pnv_smp_cpu_kill_self() which > > transitions the CPU to the deepest available platform idle state to a > > new function named pnv_cpu_offline() in powernv/idle.c. The rationale > > behind this code movement is that the data required to determine the > > deepest available platform state resides in powernv/idle.c. > > > > Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com> > > Looks good. As a nitpick, possibly one or two variables in idle.c could > become static (pnv_deepest_stop_psscr_*). >
I changed that, but it ended up being in the next patch.
> Reviewed-by: Nicholas Piggin <npiggin@gmail.com> >
Thanks!
-- Thanks and Regards gautham.
| |