Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH v2 6/6] selftests: enable O and KBUILD_OUTPUT | Date | Wed, 22 Mar 2017 22:46:11 +1100 |
| |
Shuah Khan <shuahkh@osg.samsung.com> writes:
> On 03/21/2017 03:00 AM, Bamvor Zhang Jian wrote: >> On 21 March 2017 at 16:35, Michael Ellerman <mpe@ellerman.id.au> wrote: >>> Andy Lutomirski <luto@amacapital.net> writes: >>>> On Tue, Nov 29, 2016 at 3:55 AM, <bamvor.zhangjian@huawei.com> wrote: >>>>> From: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org> >>>>> >>>>> Enable O and KBUILD_OUTPUT for kselftest. User could compile kselftest >>>>> to another directory by passing O or KBUILD_OUTPUT. And O is high >>>>> priority than KBUILD_OUTPUT. >>>> >>>> Sorry for noticing this late, but this patch >>>> (a8ba798bc8ec663cf02e80b0dd770324de9bafd9) is really annoying for >>>> people who *don't* use these fancy options: >>> >>> Yeah sorry, it wasn't quite ready to go in. > > Bamovar, > > Please give me heads up and ask me to not commit the patch, > if you think it isn't ready.
That was me who wrote that above.
>> Do we really need "make -C tools/testing/selftests/x86 ldt_gdt_32"? >> It is useful but it will skip the top level Makefile of selftests. > > Being able to build individual tests is an important use-case.
Then it needs to be tested before changes are merged.
cheers
| |