Messages in this thread | | | Subject | Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt | From | Steve Longerbeam <> | Date | Tue, 21 Mar 2017 16:33:29 -0700 |
| |
Hi Philipp, Russell,
On 03/20/2017 10:23 AM, Philipp Zabel wrote: > Hi Steve, Russell, > > <snip> > > What do you think of this: > > ----------8<---------- > From 2830aebc404bdfc9d7fc1ec94e5282d0b668e8f6 Mon Sep 17 00:00:00 2001 > From: Philipp Zabel <p.zabel@pengutronix.de> > Date: Mon, 20 Mar 2017 17:10:21 +0100 > Subject: [PATCH] media: imx: csi: add sink selection rectangles > > Move the crop rectangle to the sink pad and add a sink compose rectangle > to configure scaling. Also propagate rectangles from sink pad to crop > rectangle, to compose rectangle, and to the source pads both in ACTIVE > and TRY variants of set_fmt/selection, and initialize the default crop > and compose rectangles. >
I applied this patch.
I noticed Philipp fixed a bug in the sink->source pad format propagation. I was only propagating the active runs, and not the trial runs. I fixed this everywhere in the pipeline, applied to the "propagate sink pad formats to source pads" patch. Try runs should now work correctly across the whole pipeline, but I haven't tested this.
Steve
| |