Messages in this thread | | | Date | Tue, 21 Mar 2017 17:27:00 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH v3 2/3] drm/pl111: Initial drm/kms driver for pl111 |
| |
On Mon, Mar 20, 2017 at 04:36:14PM -0700, Eric Anholt wrote: > +static struct amba_driver pl111_amba_driver = { > + .drv = { > + .name = "clcd-pl11x",
either:
.name = "clcd-pl111",
or:
.name = "drm-clcd-pl111",
otherwise the driver names will clash in sysfs - driver names must be unique.
> + }, > + .probe = pl111_amba_probe, > + .remove = pl111_amba_remove, > + .id_table = pl111_id_table, > +}; > +#endif /* CONFIG_ARM_AMBA */ > + > +module_amba_driver(pl111_amba_driver); > + > +MODULE_DESCRIPTION(DRIVER_DESC); > +MODULE_AUTHOR("ARM Ltd."); > +MODULE_LICENSE("GPL"); > +MODULE_ALIAS("platform:pl111_drm");
Does the platform alias make sense for an OF-only driver?
-- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
| |