Messages in this thread | | | Subject | Re: [PATCH] fix ptr_ret.cocci warnings | From | Daniel Thompson <> | Date | Tue, 21 Mar 2017 15:07:26 +0000 |
| |
On 21/03/17 14:58, Olimpiu Dejeu wrote: > On Fri, Mar 17, 2017 at 10:48 AM, kbuild test robot <lkp@intel.com> wrote: >> drivers/video/backlight/arcxcnn_bl.c:183:1-3: WARNING: PTR_ERR_OR_ZERO can be used >> >> >> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR >> >> Generated by: scripts/coccinelle/api/ptr_ret.cocci >> >> CC: Olimpiu Dejeu <olimpiu@arcticsand.com> >> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> >> --- >> >> arcxcnn_bl.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> --- a/drivers/video/backlight/arcxcnn_bl.c >> +++ b/drivers/video/backlight/arcxcnn_bl.c >> @@ -180,10 +180,7 @@ static int arcxcnn_backlight_register(st >> >> lp->bl = devm_backlight_device_register(lp->dev, name, lp->dev, lp, >> &arcxcnn_bl_ops, props); >> - if (IS_ERR(lp->bl)) >> - return PTR_ERR(lp->bl); >> - >> - return 0; >> + return PTR_ERR_OR_ZERO(lp->bl); >> } >> >> static void arcxcnn_parse_dt(struct arcxcnn *lp) > > Acked-by: Olimpiu Dejeu <olimpiu@arcticsand.com>
Glad you approve! Could you apply this change and re-post the patch series? Thanks.
Daniel.
| |