lkml.org 
[lkml]   [2017]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration
Date


> -----Original Message-----
> From: Masahiro Yamada [mailto:yamada.masahiro@socionext.com]
> Sent: 17 March, 2017 6:24 PM
> Subject: Re: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration
>
>
>
> > @@ -62,10 +66,33 @@
> > */
> > #define SDHCI_CDNS_MAX_TUNING_LOOP 40
> >
> > +static const struct of_device_id sdhci_cdns_match[];
> > +
>
> You forgot to remove this.
>
You are right. Thanks.

>
> > @@ -227,6 +267,7 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
> > struct sdhci_cdns_priv *priv;
> > struct clk *clk;
> > int ret;
> > + struct device *dev = &pdev->dev;
> >
> > clk = devm_clk_get(&pdev->dev, NULL);
>
>
> If you add "dev", please use it for devm_clk_get, too.
>
I did on the first patch version but Ulf pointed that this is unrelated change and should be removed.
Therefore I remove it.

>
>
> --
> Best Regards
> Masahiro Yamada
\
 
 \ /
  Last update: 2017-03-20 09:52    [W:0.052 / U:6.220 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site