[lkml]   [2017]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe
On 03/20/2017 06:42 PM, Joao Pinto wrote:
> Às 5:29 PM de 3/20/2017, Niklas Cassel escreveu:
>> From: Niklas Cassel <>
>> It is usually possible to do
>> ethtool -s autoneg on
>> so that you trigger an autoneg before calling
>> ip link set dev eth0 up
>> However, stmmac returns -EBUSY if !netif_running.
>> The only reason for this appears to be that stmmac_init_phy
>> is called from stmmac_open instead of from stmmac_dvr_probe.
>> Move stmmac_init_phy to stmmac_dvr_probe so that ethool
>> works as soon as register_netdev has been called.
>> stmmac_check_ether_addr was also moved to probe,
>> so that the ordering doesn't change.
>> Signed-off-by: Niklas Cassel <>
>> ---
> Hi Niklas, did you test this patch?

I tested it on our hardware, but it would be nice
if you could test it on your side, since you are
using the PCI glue layer.

 \ /
  Last update: 2017-03-20 18:54    [W:0.047 / U:0.176 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site