Messages in this thread | | | Date | Mon, 20 Mar 2017 17:26:47 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode |
| |
On Tue, Mar 21, 2017 at 12:23:53AM +0800, Kai-Heng Feng wrote: > On Tue, Mar 21, 2017 at 12:06 AM, Mark Brown <broonie@kernel.org> wrote:
> > As it says there "...and inserted automatically following the three dash > > line".
> I saw iteration changelog in git log all over the place, maybe add a > rule section for each subsystem?
Some people won't push back, the only people who insist on anything different are the graphics people.
> I had the same thought originally, but printk under each case suggests > otherwise - _POST_PMU is triggered not right after _PRE_PMU but right > before _PRE_PMD.
Then you've broken something else on your system, that is obviously completely nonsensical and would break anything that relies on having a _POST_PMU event. Why would we have two events that run at the same time one of which is obviously misnamed?
> > > You didn't reply to my review comment and you sent the same code > > > again. > > That looks an awful lot like being ignored.
> Fair enough, I thought changelog is sufficient.
I'm not seeing anything in the changelog that addresses this. [unhandled content-type:application/pgp-signature] | |