lkml.org 
[lkml]   [2017]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: mwifiex: pcie: clean up error prints in mwifiex_pcie_reset_notify()
From
Date
Brian Norris <briannorris@chromium.org> wrote:
> We shouldn't be printing a kernel pointer as a decimal integer. But we
> really shouldn't be printing this case at all; we should never get here
> with NULL drvdata. We've eliminated this unnecessary conditional in
> several other places, so kill it here too.
>
> Similarly, there's no need to check for '!pdev'; we are guaranteed to
> have a real device here.
>
> And finally, use dev_err() instead of pr_err().
>
> This yields (for failed PCIe resets):
>
> [ 68.286586] mwifiex_pcie 0000:01:00.0: mwifiex_pcie_reset_notify: adapter structure is not valid
>
> instead of:
>
> [ 82.932658] mwifiex_pcie: mwifiex_pcie_reset_notify: Card or adapter structure is not valid (-270880688088)
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Patch applied to wireless-drivers-next.git, thanks.

520334156213 mwifiex: pcie: clean up error prints in mwifiex_pcie_reset_notify()

--
https://patchwork.kernel.org/patch/9609861/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

\
 
 \ /
  Last update: 2017-03-20 18:13    [W:0.032 / U:0.872 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site