lkml.org 
[lkml]   [2017]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/6 v3] ftrace/x86_32: Clean up ftrace_regs_caller
On Sat, Mar 18, 2017 at 05:09:27PM -0400, Steven Rostedt wrote:
> @@ -111,12 +114,11 @@ GLOBAL(ftrace_regs_call)
> popl %es
> popl %fs
> popl %gs
> - addl $8, %esp /* Skip orig_ax and ip */
> - popf /* Pop flags at end (no addl to corrupt flags) */
> - jmp .Lftrace_ret
>
> - popf
> - jmp ftrace_stub
> + /* use lea to not affect flags */
> + lea 3*4(%esp), %esp /* Skip orig_ax, ip and flags */
> +
> + jmp .Lftrace_ret
> #else /* ! CONFIG_DYNAMIC_FTRACE */
>
> ENTRY(mcount)

That last comment should be

/* Skip orig_ax, ip and cs */

Otherwise:

Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>

--
Josh

\
 
 \ /
  Last update: 2017-03-20 15:27    [W:0.078 / U:30.612 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site