Messages in this thread | | | Subject | Re: [PATCH v2] drm/bridge: dw_hdmi: support i2c extended read mode | From | Vladimir Zapolskiy <> | Date | Mon, 20 Mar 2017 13:55:50 +0200 |
| |
Hi Nickey,
On 03/20/2017 04:57 AM, Nickey Yang wrote: > "I2C Master Interface Extended Read Mode" implements a segment > pointer-based read operation using the Special Register configuration. > > This patch fix https://patchwork.kernel.org/patch/7098101/ mentioned > "The current implementation does not support "I2C Master Interface > Extended Read Mode" to read data addressed by non-zero segment > pointer, this means that if EDID has more than 1 extension blocks"
... EDID reading operation won't succeed.
Indeed.
> > With this patch,dw-hdmi can read EDID data with 1/2/4 blocks. > > Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com> > Reviewed-by: Douglas Anderson <dianders@chromium.org> > ---
Unfortunately I don't have a chance to test the change thoroughly, but from what I see the implementation is correct. Thank you for the change.
Please feel free to update the commit message and add my
Acked-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
-- With best wishes, Vladimir
| |