Messages in this thread | | | Date | Mon, 20 Mar 2017 12:07:18 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls |
| |
Hello Geert,
On Mon, Mar 20, 2017 at 11:38:52AM +0100, Geert Uytterhoeven wrote: > On Mon, Mar 20, 2017 at 11:31 AM, Uwe Kleine-König > <u.kleine-koenig@pengutronix.de> wrote: > > On Mon, Mar 20, 2017 at 10:56:14AM +0100, Geert Uytterhoeven wrote: > >> Documentation/gpio/consumer.txt rightfully sates: > >> | Note that gpio_get*_optional() functions (and their managed variants), unlike > >> | the rest of gpiolib API, also return NULL when gpiolib support is disabled. > >> | This is helpful to driver authors, since they do not need to special case > >> | -ENOSYS return codes. System integrators should however be careful to enable > >> | gpiolib on systems that need it. > > > > I cannot find this paragraph in Documentation/gpio/consumer.txt: > > > > $ git grep -e 'ENOSYS' v4.11-rc3 -- Documentation/gpio/ > > <void> > > It was added by commit 22c403676dbbb7c6 ("gpio: return NULL from > gpiod_get_optional when GPIOLIB is disabled")
Ah, that's in next.
I still think this is wrong and I'm a bit disappointed that Linus merged this patch (without saying so in the thread even) as I thought Linus and I agreed on this being a bad idea.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
| |