lkml.org 
[lkml]   [2017]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sched: Wake up all non-exclusive waiters in __wake_up_common()
On Wed, Mar 08, 2017 at 09:21:52AM +0900, Byungchul Park wrote:
> __wake_up_common() should wake up all non-exclusive waiters and
> exclusive waiters as many as nr_exclusive, but currently it does not.
>
> Consider a wait queue like the following for example:
>
> A(exclusive) -> B(non-exclusive) -> C(non-exclusive)
>
> Current code will wake up only A when nr_exclusive = 1, but has to wake
> up A, B and C. Make it do as we expect.

You have the list oredered the wrong way around. We add exclusive
waiters to the tail, therefore we'll have woken up all the !exclusive
waiters before we start decrementing nr_exclusive.

\
 
 \ /
  Last update: 2017-03-20 11:43    [W:0.059 / U:7.900 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site