lkml.org 
[lkml]   [2017]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/2] sched/deadline: Remove unnecessary condition in push_dl_task()
On Thu, Feb 16, 2017 at 06:35:54PM +0100, Daniel Bristot de Oliveira wrote:
> On 02/16/2017 03:34 AM, Byungchul Park wrote:
> > pick_next_pushable_dl_task(rq) has BUG_ON(rq->cpu != task_cpu(task))
> > when it returns a task other than NULL, which means that task_cpu(task)
> > must be rq->cpu. So if task == next_task, then task_cpu(next_task) must
> > be rq->cpu as well. Remove the redundant condition and make code simpler.
> >
> > By this patch, unnecessary one branch and two LOAD operations in 'if'
> > statement can be avoided.
> >
> > Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> > Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > Reviewed-by: Juri Lelli <juri.lelli@arm.com>
>
> +1
>
> Reviewed-by: Daniel Bristot de Oliveira <bristot@redhat.com>

Hello,

Could you check this out?

>
> -- Daniel

\
 
 \ /
  Last update: 2017-03-21 03:58    [W:0.066 / U:12.800 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site