[lkml]   [2017]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [Intel-wired-lan] [PATCH] i40e: fix memcpy with swapped arguments
> -----Original Message-----
> From: Intel-wired-lan [] On
> Behalf Of Colin King
> Sent: Monday, March 20, 2017 7:46 AM
> To: Kirsher, Jeffrey T <>; intel-wired-
> Cc:;
> Subject: [Intel-wired-lan] [PATCH] i40e: fix memcpy with swapped arguments
> From: Colin Ian King <>

Hi there,

> The current code copies an uninitialized params into
> cdev->lan_info.params and then passes the uninitialized params
> to the call cdev->client->ops->l2_param_change. I believe the
> order of the source and destination in the memcpy is the wrong
> way around and should be swapped.

So you are correct that params is uninitialized. However, the fix here is not correct. Somehow we dropped the code for initializing the parameters.

See commit d7ce6422d6e6 ("i40e: don't check params until after checking for client instance", 2017-02-09) It looks like the commit itself was malformed when applied upstream, and a later commit which should have preserved the changes 3140aa9a78c9 ("i40e: KISS the client interface", 2017-03-14) accidentally dropped them.

I'll provide a patch to get this back into the correct state.

Thanks for catching this.

 \ /
  Last update: 2017-03-21 00:34    [W:0.030 / U:7.560 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site