lkml.org 
[lkml]   [2017]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 2/3] printk: rename selected_console -> preferred_console
    On (03/02/17 10:01), Steven Rostedt wrote:
    > > The variable selected_console is set in __add_preferred_console()
    > > to point to the last console parameter that was added to the
    > > console_cmdline array.
    > >
    > > Rename it to preferred_console so that the name reflects the usage.
    >
    > As I said previously, I prefer "selected_console" but since
    > "__add_preferred_console()" sets it, I'm fine with this change.
    > Although, I would probably have changed that function to
    > "__add_selected_console()" :)
    >
    > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

    agree, I'd *probably* do a function rename. just 3 lines of code to
    touch (afaics).

    Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

    -ss

    \
     
     \ /
      Last update: 2017-03-02 17:43    [W:3.699 / U:1.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site