Messages in this thread | | | Date | Fri, 3 Mar 2017 01:09:28 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH v2 2/3] printk: rename selected_console -> preferred_console |
| |
On (03/02/17 10:01), Steven Rostedt wrote: > > The variable selected_console is set in __add_preferred_console() > > to point to the last console parameter that was added to the > > console_cmdline array. > > > > Rename it to preferred_console so that the name reflects the usage. > > As I said previously, I prefer "selected_console" but since > "__add_preferred_console()" sets it, I'm fine with this change. > Although, I would probably have changed that function to > "__add_selected_console()" :) > > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
agree, I'd *probably* do a function rename. just 3 lines of code to touch (afaics).
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
| |