lkml.org 
[lkml]   [2017]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/10] Bluetooth: hci_uart: add support for word alignment
    Hi!

    > This will be used by Nokia's H4+ protocol, which
    > uses 2-byte aligned packets.
    >
    > Signed-off-by: Sebastian Reichel <sre@kernel.org>

    Acked-by: Pavel Machek <pavel@ucw.cz>

    > --- a/drivers/bluetooth/hci_h4.c
    > +++ b/drivers/bluetooth/hci_h4.c
    > @@ -171,9 +171,20 @@ struct sk_buff *h4_recv_buf(struct hci_dev *hdev, struct sk_buff *skb,
    > const unsigned char *buffer, int count,
    > const struct h4_recv_pkt *pkts, int pkts_count)
    > {
    > + struct hci_uart *hu = hci_get_drvdata(hdev);
    > + uint8_t alignment = hu->alignment;

    I'd do u8 here, too, for consistency with struct below (and becuase
    uint8_t is somehow unusual in kernel).

    > @@ -92,6 +92,9 @@ struct hci_uart {
    >
    > unsigned int init_speed;
    > unsigned int oper_speed;
    > +
    > + u8 alignment;
    > + u8 padding;
    > };
    >

    Thanks,
    Pavel

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2017-03-17 16:26    [W:2.302 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site