lkml.org 
[lkml]   [2017]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks
    From
    Date
    On Thu, 2017-03-16 at 11:56 +0100, Michal Hocko wrote:
    > On Wed 15-03-17 18:43:13, Joe Perches wrote:
    > > Function calls with large argument counts cause x86-64 register
    > > spilling. Reducing the number of arguments in a multi-line printk
    > > by converting to multiple printks which saves some object code size.
    > >
    > > $ size mm/page_alloc.o* (defconfig)
    > > text data bss dec hex filename
    > > 35914 1699 628 38241 9561 mm/page_alloc.o.new
    > > 36018 1699 628 38345 95c9 mm/page_alloc.o.old
    > >
    > > Miscellanea:
    > >
    > > o Remove line leading spaces from the formerly multi-line printks
    > > commit a25700a53f71 ("mm: show bounce pages in oom killer output")
    > > back in 2007 started the leading space when a single long line
    > > was split into multiple lines but the leading space was likely
    > > mistakenly kept and subsequent commits followed suit.
    > > o Align arguments in a few more printks
    >
    > This is really hard to review. Could you just drop all the whitespace
    > changes please?

    It's a single, simple change. It's IMO trivial to review.

    \
     
     \ /
      Last update: 2017-03-16 21:33    [W:4.592 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site