Messages in this thread | | | From | "Jayachandran C." <> | Date | Thu, 16 Mar 2017 12:41:18 +0530 | Subject | Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console" |
| |
Hi Greg,
On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla <sudeep.holla@arm.com> wrote: > > > On 01/03/17 15:23, Aleksey Makarov wrote: >> The original patch makes the condition always true, so it is wrong. >> >> It masks (but not fixes) the bug described in the commit message >> but introduces a regression (no console is selected by SPCR) >> in regular (no 'console=ttyAMA') case. >> >> s/||/&&/ would not fix the problem as the root cause was identified >> incorrectly. >> >> This reverts commit aea9a80ba98a0c9b4de88850260e9fbdcc98360b. >> > > Sorry for that, I will test your patches and respond to that. For this > patch: > > Acked-by: Sudeep Holla <sudeep.holla@arm.com> >
This fixes a regression I see in v4.11-rc2
Tested-by: Jayachandran C <jnair@caviumnetworks.com>
I don't see it in the tty/serial tree yet
JC.
| |