Messages in this thread | | | Date | Thu, 16 Mar 2017 10:20:37 +0100 | From | Benjamin Tissoires <> | Subject | Re: [PATCH v2 04/15] HID: logitech-hidpp: battery: remove overloads and provide ONLINE |
| |
On Feb 08 2017 or thereabouts, Bastien Nocera wrote: > On Thu, 2017-02-02 at 15:12 +0100, Benjamin Tissoires wrote: > > When ONLINE isn't set, upower should ignore the battery capacity, so > > there > > is no need to overload it with some random values. > > In usage, the capacity value will drop to "0": > -(/sys/class/power_supply/hidpp_battery_1)-> cat capacity > 0 > -(/sys/class/power_supply/hidpp_battery_1)-> cat online > 1 >
Heh, just found out what happened here: we were not checking on the report ID, which means that hitting the 'f' key alone generated a report that was interpreted by hid-logitech-hidpp as a battery event with a null capacity :)
Anyway, fixed locally so does the full series that has seen a big clean up. I'll ask Bastien for some tests and will post a v3 soon.
Cheers, Benjamin
> And GNOME will popup a warning about the device.
| |