Messages in this thread | | | Subject | Re: [PATCH 3/4] uapi glibc compat: Do not check for __USE_MISC | From | David Woodhouse <> | Date | Thu, 16 Mar 2017 07:59:12 +0000 |
| |
On Sun, 2017-03-12 at 23:00 +0100, Hauke Mehrtens wrote: > __USE_MISC is glibc specific and not available in musl libc. Only do > this check when glibc is used. This fixes a problem with musl libc. > ... > -/* Coordinate with glibc net/if.h header. */ > -#if defined(_NET_IF_H) && defined(__USE_MISC) > +/* Coordinate with libc net/if.h header. */ > +#if defined(_NET_IF_H) && (!defined(__GLIBC__) || defined(__USE_MISC))
I *really* don't like building up a plethora of knowledge about specific libc implementations in the kernel. As a general rule, if we have *anything* that depends on __GLIBC__ then we are Doing It Wrong™.[unhandled content-type:application/x-pkcs7-signature] | |