Messages in this thread | | | Subject | Re: [PATCH v2 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64 | From | Florian Fainelli <> | Date | Tue, 14 Mar 2017 11:20:31 -0700 |
| |
On 03/14/2017 07:18 AM, Corentin Labbe wrote: > The dwmac-sun8i hardware is present on the pine64 > It uses an external PHY via RMII. > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > --- > arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts > index c680ed3..b53994d 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts > @@ -109,3 +109,18 @@ > &usbphy { > status = "okay"; > }; > + > +&mdio { > + ext_rmii_phy1: ethernet-phy@1 { > + reg = <1>;
Even though it's optional, it's nice to have a:
compatible = "ethernet-phy-ieee802.3-c22"
string here.
This applies to all DTS files that you have in subsequent patches.
Thanks! -- Florian
| |