Messages in this thread | | | Date | Tue, 14 Mar 2017 13:51:31 +0200 | From | Mika Westerberg <> | Subject | Re: [PATCH v1 1/4] gpio: acpi: Don't return 0 on acpi_gpio_count() |
| |
On Tue, Mar 14, 2017 at 10:43:02AM +0100, Linus Walleij wrote: > On Mon, Feb 20, 2017 at 5:15 PM, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > It's unusual to have error checking like (ret <= 0) in cases when > > counting GPIO resources. In case when it's mandatory we propagate the > > error (-ENOENT), otherwise we don't use the result. > > > > This makes consistent behaviour across all possible variants called in > > gpiod_count(). > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Mika/Rafael, can you look at this patch?
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
| |