Messages in this thread | | | Subject | Re: [PATCH v2 10/21] x86/xen: split off smp_hvm.c | From | Juergen Gross <> | Date | Mon, 13 Mar 2017 08:37:42 +0100 |
| |
On 02/03/17 18:53, Vitaly Kuznetsov wrote: > Move PVHVM related code to smp_hvm.c. Drop 'static' qualifier from > xen_smp_send_reschedule(), xen_smp_send_call_function_ipi(), > xen_smp_send_call_function_single_ipi(), these functions will be moved to > common smp code when smp_pv.c is split. > > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
One nit below, with this addressed:
Reviewed-by: Juergen Gross <jgross@suse.com>
> --- > arch/x86/xen/Kconfig | 4 ++++ > arch/x86/xen/Makefile | 1 + > arch/x86/xen/smp.c | 57 +++---------------------------------------------- > arch/x86/xen/smp.h | 3 +++ > arch/x86/xen/smp_hvm.c | 58 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 69 insertions(+), 54 deletions(-) > create mode 100644 arch/x86/xen/smp_hvm.c >
> diff --git a/arch/x86/xen/smp.h b/arch/x86/xen/smp.h > index a059adb..bf36e79 100644 > --- a/arch/x86/xen/smp.h > +++ b/arch/x86/xen/smp.h > @@ -14,6 +14,9 @@ extern void xen_smp_intr_free(unsigned int cpu); > extern int xen_smp_intr_init_pv(unsigned int cpu); > extern void xen_smp_intr_free_pv(unsigned int cpu); > > +extern void xen_smp_send_reschedule(int cpu); > +extern void xen_smp_send_call_function_ipi(const struct cpumask *mask); > +extern void xen_smp_send_call_function_single_ipi(int cpu);
Could you please drop the "extern" qualifier when adding new function prototypes? I know this just follows the style of the file, but I'd prefer not to add new instances.
Juergen
| |