Messages in this thread | | | Date | Mon, 13 Mar 2017 14:00:10 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 1/2] x86/mm/numa: trivial fix on typo and error message |
| |
On Mon, Feb 06, 2017 at 11:35:28PM +0800, Wei Yang wrote: > When allocating pg_data in alloc_node_data(), it will try to allocate from > local node first and then from any node. If it fails at the second trial, > it means there is not available memory on any node. > > This patch fixes the error message and correct one typo. > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> > --- > arch/x86/mm/numa.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c > index 4366242356c5..3e9110b34147 100644 > --- a/arch/x86/mm/numa.c > +++ b/arch/x86/mm/numa.c > @@ -201,8 +201,8 @@ static void __init alloc_node_data(int nid) > nd_pa = __memblock_alloc_base(nd_size, SMP_CACHE_BYTES, > MEMBLOCK_ALLOC_ACCESSIBLE); > if (!nd_pa) { > - pr_err("Cannot find %zu bytes in node %d\n", > - nd_size, nid); > + pr_err("Cannot find %zu bytes in any node\n", > + nd_size); > return; > }
Actually, the best would be:
pr_err("Cannot find %zu bytes in any node (initial node: %d)\n", nd_size, nid);
or something like that. This way you say
a) the initial node %nid failed b) the fallback to any node failed too
so that people trying to debug code can have the complete info in the logs.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |