lkml.org 
[lkml]   [2017]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6/7] Input: kbtab - fix NULL-deref at probe
    Date
    Make sure to check the number of endpoints to avoid dereferencing a
    NULL-pointer should a malicious device lack endpoints.

    Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: Johan Hovold <johan@kernel.org>
    ---
    drivers/input/tablet/kbtab.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/input/tablet/kbtab.c b/drivers/input/tablet/kbtab.c
    index e850d7e8afbc..4d9d64908b59 100644
    --- a/drivers/input/tablet/kbtab.c
    +++ b/drivers/input/tablet/kbtab.c
    @@ -122,6 +122,9 @@ static int kbtab_probe(struct usb_interface *intf, const struct usb_device_id *i
    struct input_dev *input_dev;
    int error = -ENOMEM;

    + if (intf->cur_altsetting->desc.bNumEndpoints < 1)
    + return -ENODEV;
    +
    kbtab = kzalloc(sizeof(struct kbtab), GFP_KERNEL);
    input_dev = input_allocate_device();
    if (!kbtab || !input_dev)
    --
    2.12.0
    \
     
     \ /
      Last update: 2017-03-13 13:38    [W:5.084 / U:0.356 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site