lkml.org 
[lkml]   [2017]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Outreachy kernel] [PATCH] staging: android: Replace strcpy with strlcpy


    On Sun, 12 Mar 2017, simran singhal wrote:

    > Replace strcpy with strlcpy as strcpy does not check for buffer
    > overflow.
    > This is found using Flawfinder.
    >
    > Signed-off-by: simran singhal <singhalsimran0@gmail.com>
    > ---
    > drivers/staging/android/ashmem.c | 3 ++-
    > 1 file changed, 2 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
    > index 7cbad0d..eb2f4ef 100644
    > --- a/drivers/staging/android/ashmem.c
    > +++ b/drivers/staging/android/ashmem.c
    > @@ -548,7 +548,8 @@ static int set_name(struct ashmem_area *asma, void __user *name)
    > if (unlikely(asma->file))
    > ret = -EINVAL;
    > else
    > - strcpy(asma->name + ASHMEM_NAME_PREFIX_LEN, local_name);
    > + strlcpy(asma->name + ASHMEM_NAME_PREFIX_LEN, local_name,
    > + sizeof(asma->name + ASHMEM_NAME_PREFIX_LEN));

    There is a parenthesis in the wrong place.

    julia

    >
    > mutex_unlock(&ashmem_mutex);
    > return ret;
    > --
    > 2.7.4
    >
    > --
    > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
    > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
    > To post to this group, send email to outreachy-kernel@googlegroups.com.
    > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170311204001.GA13301%40singhal-Inspiron-5558.
    > For more options, visit https://groups.google.com/d/optout.
    >

    \
     
     \ /
      Last update: 2017-03-11 21:48    [W:3.346 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site