lkml.org 
[lkml]   [2017]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] powerpc: sysdev: cpm1: Optimise gpio bit calculation
On Fri, Mar 10, 2017 at 11:54:19AM +0100, Christophe LEROY wrote:
> gpio_get() and gpio_set() are used extensively by some GPIO based
> drivers like SPI, NAND, so it may be worth it as it doesn't impair
> readability (if anyone prefers, we could write (1 << 31) >> i instead
> of 0x80000000 >> i )

1 << 31 is undefined behaviour, of course.


Segher

\
 
 \ /
  Last update: 2017-03-10 14:16    [W:0.043 / U:3.872 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site